converted zyd(4) Was: [Testers needed!] WiFi drivers changes

[Gleb Smirnoff]

Hi Kevin,

you signed up as tester of zyd(4). I have converted zyd(4)
and uploaded new patch at:

https://reviews.freebsd.org/D2655

Please try, report and update the project page.

https://wiki.freebsd.org/projects/ifnet/net80211

Thanks a lot for your help.

[Kevin Lo]

Post by Gleb Smirnoff
Hi Kevin,

Hi Gleb,

Post by Gleb Smirnoff
you signed up as tester of zyd(4). I have converted zyd(4)
https://reviews.freebsd.org/D2655
Please try, report and update the project page.
https://wiki.freebsd.org/projects/ifnet/net80211
Thanks a lot for your help.

Works for me, thanks.

# dmesg |grep zyd
zyd0: <SMC USB2.0 WLAN, rev 2.00/48.10, addr 2> on usbus4
zyd0: HMAC ZD1211B, FW 47.25, RF AL2230 S1, PA0 LED 0 BE0 NP1 Gain1 F0

# netstat -hI wlan0 1
input wlan0 output
packets errs idrops bytes packets errs bytes colls
418 198 0 610K 212 24 22K 0
278 117 0 403K 138 26 14K 0
362 142 0 530K 165 33 17K 0
329 180 0 477K 180 11 18K 0
413 178 0 601K 197 21 20K 0
446 206 0 655K 220 22 23K 0
344 163 0 500K 182 30 19K 0
400 176 0 583K 189 20 19K 0
377 175 0 548K 191 26 20K 0
393 183 0 573K 191 21 20K 0
338 147 0 494K 164 29 17K 0
386 186 0 565K 198 20 20K 0
446 234 0 654K 235 14 24K 0
390 170 0 570K 189 25 19K 0
348 169 0 507K 179 16 18K 0
366 165 0 533K 175 14 18K 0
336 150 0 491K 161 17 17K 0
378 183 0 553K 198 18 20K 0
382 191 0 559K 197 9 20K 0
397 173 0 581K 184 14 19K 0
368 172 0 536K 188 21 19K 0

Post by Gleb Smirnoff
--
Totus tuus, Glebius.

Kevin

[Gleb Smirnoff]

Hi Kevin,

you signed up as tester of urtw(4). I have converted urtw(4)
and uploaded new patch at:

https://reviews.freebsd.org/D2655

Please try, report and update the project page.

https://wiki.freebsd.org/projects/ifnet/net80211

Thanks a lot for your help with the project.

[Kevin Lo]

Post by Gleb Smirnoff
Hi Kevin,
you signed up as tester of urtw(4). I have converted urtw(4)
https://reviews.freebsd.org/D2655
Please try, report and update the project page.
https://wiki.freebsd.org/projects/ifnet/net80211
Thanks a lot for your help with the project.

After bringing interface up I'm getting:
Loading Image...

Post by Gleb Smirnoff
--
Totus tuus, Glebius.

Kevin

[Olivier Cochard-Labbé]

Post by Kevin Lo
http://i.imgur.com/XhOVJ68.jpg

​I didn't meet this problem on head (r284301) with D2655 applied and using
an Alpha network AWUS036NHR v.2

​

[Gleb Smirnoff]

On Thu, Jun 18, 2015 at 12:04:55PM +0200, Olivier Cochard-Labbé wrote:
O> > After bringing interface up I'm getting:
O> > http://i.imgur.com/XhOVJ68.jpg
O> >
O> ​I didn't meet this problem on head (r284301) with D2655 applied and using
O> an Alpha network AWUS036NHR v.2

Which is urtwn, not urtw.

[Gleb Smirnoff]

On Thu, Jun 18, 2015 at 04:16:55PM +0800, Kevin Lo wrote:
K> > you signed up as tester of urtw(4). I have converted urtw(4)
K> > and uploaded new patch at:
K> >
K> > https://reviews.freebsd.org/D2655
K> >
K> > Please try, report and update the project page.
K> >
K> > https://wiki.freebsd.org/projects/ifnet/net80211
K> >
K> > Thanks a lot for your help with the project.
K>
K> After bringing interface up I'm getting:
K> http://i.imgur.com/XhOVJ68.jpg

What's the actual assertion in the mutex code?

[Gleb Smirnoff]

On Thu, Jun 18, 2015 at 04:16:55PM +0800, Kevin Lo wrote:
K> > you signed up as tester of urtw(4). I have converted urtw(4)
K> > and uploaded new patch at:
K> >
K> > https://reviews.freebsd.org/D2655
K> >
K> > Please try, report and update the project page.
K> >
K> > https://wiki.freebsd.org/projects/ifnet/net80211
K> >
K> > Thanks a lot for your help with the project.
K>
K> After bringing interface up I'm getting:
K> http://i.imgur.com/XhOVJ68.jpg

I've found the problem and updated the diff. Please test once more.

Thanks for help! Without you the bug could leak into subversion.

[Kevin Lo]

Post by Gleb Smirnoff
K> > you signed up as tester of urtw(4). I have converted urtw(4)
K> >
K> > https://reviews.freebsd.org/D2655
K> >
K> > Please try, report and update the project page.
K> >
K> > https://wiki.freebsd.org/projects/ifnet/net80211
K> >
K> > Thanks a lot for your help with the project.
K>
K> http://i.imgur.com/XhOVJ68.jpg
I've found the problem and updated the diff. Please test once more.
Thanks for help! Without you the bug could leak into subversion.

Thank you Gleb. urtw(4) works fine on amd64.

# dmesg |grep urtw
urtw0: <vendor 0x0bda product 0x8187, class 0/0, rev 2.00/1.00, addr 2> on usbus4
urtw0: unknown RTL8187L type: 0x8000000
urtw0: rtl8187l rf rtl8225u hwrev none

One minor problem, I got an compiler error and this diff below fixes it.

--- D2655.diff.orig 2015-06-22 09:45:48.836385086 +0800
+++ D2655.diff 2015-06-22 09:47:56.121431950 +0800
@@ -10421,14 +10421,6 @@
struct urtw_vap *uvp = URTW_VAP(vap);
struct ieee80211_node *ni;
usb_error_t error = 0;
-@@ -1905,7 +1858,6 @@
- default:
- break;
- }
--fail:
- URTW_UNLOCK(sc);
- IEEE80211_LOCK(ic);
- return (uvp->newstate(vap, nstate, arg));
@@ -1915,12 +1867,11 @@
urtw_watchdog(void *arg)
{

Post by Gleb Smirnoff
--
Totus tuus, Glebius.

Kevin

[Gleb Smirnoff]

On Mon, Jun 22, 2015 at 09:51:23AM +0800, Kevin Lo wrote:
K> Thank you Gleb. urtw(4) works fine on amd64.

Thanks.

K> One minor problem, I got an compiler error and this diff below fixes it.
K>
K> --- D2655.diff.orig 2015-06-22 09:45:48.836385086 +0800
K> +++ D2655.diff 2015-06-22 09:47:56.121431950 +0800
K> @@ -10421,14 +10421,6 @@
K> struct urtw_vap *uvp = URTW_VAP(vap);
K> struct ieee80211_node *ni;
K> usb_error_t error = 0;
K> -@@ -1905,7 +1858,6 @@
K> - default:
K> - break;
K> - }
K> --fail:
K> - URTW_UNLOCK(sc);
K> - IEEE80211_LOCK(ic);
K> - return (uvp->newstate(vap, nstate, arg));
K> @@ -1915,12 +1867,11 @@
K> urtw_watchdog(void *arg)
K> {

This patch is unclear to me. Can you please send a diff between my version
and your version? Diff of diff drives me mad.